Skip to content

BUG: scalar indexing on 2D DTA/TDA/PA #33342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Apr 10, 2020
Merged

BUG: scalar indexing on 2D DTA/TDA/PA #33342

merged 28 commits into from
Apr 10, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 6, 2020 •
edited
Loading

cc @jorisvandenbossche this fixes the issue with DatetimeLikeBlockMixin.iget discussed in #33252

Note: this sits on top of #33290.

jbrockmendel and others added 28 commits April 4, 2020 12:22
@jbrockmendel
BUG: 2D indexing on DTA/TDA/PA
03d07df
@tv3141 @jbrockmendel
BUG: Fix segfault in GroupBy.count and DataFrame.count (pandas-dev#32842
8cf6c3b 
)
@jbrockmendel
TYP: require Index objects earlier in internals (pandas-dev#33100)
7072981
@ShaharNaveh @jbrockmendel
DOC: Fixed examples in pandas/core/accessor.py (pandas-dev#33260)
9526c32
@jbrockmendel
Troubleshoot Travis (pandas-dev#33280)
87c4704
@BenjaminLiuPenrose @jbrockmendel
TST: add DataFrame test for construct from tuple case from pandas-dev…
de53657 
…GH-32776 (pandas-dev#33267)
@ShaharNaveh @jbrockmendel
DOC: Fixed examples in pandas/core/window (pandas-dev#33266)
c1f2906
@farhanreynaldo @jbrockmendel
DOC: Fix error in Series.clip and DataFrame.clip (pandas-dev#33282)
f98db69
@ShaharNaveh @jbrockmendel
TYP: Fixed type annotaions in `scripts/validate_rst_title_capitalizat…
1de584d 
…ion` (pandas-dev#33268)
@simonjayhawkins @jbrockmendel
TYP: pandas/core/dtypes/dtypes.py (pandas-dev#31384)
d507fe6
@BenjaminLiuPenrose @jbrockmendel
TST: add date range test for reindex case from pandas-devGH-32740 (pa…
b7c9824 
…ndas-dev#33265)

* add test on date range timezone reindex

* undo

* fix

* move code to datetime test

* import timedelta

* adding assertion the np array results

* comply to coding standard

* update

* update

* assert_numpy_array_equal

* comply black format

* format checking

* white space

* bleck
@jbrockmendel
REF: BlockManager.combine -> _combine (pandas-dev#33294)
adba667
@jbrockmendel
REF: make kwargs explicit in BlockManager methods (pandas-dev#33295)
5550f27
@simonjayhawkins @jbrockmendel
DOC/CLN: remove versionadded/changed:: 0.21 (pandas-dev#33301)
7113911
@rhshadrach @jbrockmendel
CLN: Add/refine type hints to some functions in core.dtypes.cast (pan…
9c74fc9 
…das-dev#33286)
@jbrockmendel
DEPR: Index.is_mixed (pandas-dev#33291)
d1cc4e7
@ShaharNaveh @jbrockmendel
CLN: Added static types _libs/algos (pandas-dev#33271)
57a6537
@jbrockmendel
CLN: remove BlockManager.__contains__ (pandas-dev#33293)
55171c2
@ShaharNaveh @jbrockmendel
DOC: Improved doc for Index.equals (pandas-dev#33289)
eb080f3
@dsaxton @jbrockmendel
DOC/CLN: Fix docstring typo (pandas-dev#33320)
2f5af5e
@jbrockmendel
DOC: include Offset.__call__ to autosummary to fix sphinx warning (pa…
dfa6f44 
…ndas-dev#33309)
@neilkg @jbrockmendel
BUG: DataFrame._item_cache not cleared on on .copy() (pandas-dev#33299)
c52f831
@ShaharNaveh @jbrockmendel
CLN: Added static types for pandas/_libs/reduction.pyx (pandas-dev#…
563a64e 
…33316)
@ShaharNaveh @jbrockmendel
Changed files permissions to be the same (pandas-dev#33318)
b44021d 
Co-authored-by: MomIsBestFriend <>
@jorisvandenbossche @jbrockmendel
PERF: fix placement when slicing a Series (pandas-dev#33324)
927b695
@jbrockmendel
BUG: scalar lookup on 2D DTA/TDA/PA
2f3cd7d
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into bl…
8a1700e 
…k-iget
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into bl…
04d9f63 
…k-iget
@jbrockmendel jbrockmendel added Bug Indexing Related to indexing on series/frames, not to indexes themselves labels Apr 7, 2020
@jorisvandenbossche
Copy link
Member

@jbrockmendel now #33290 is merged, this can be updated / merged?

jorisvandenbossche
jorisvandenbossche approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone Apr 10, 2020
@jbrockmendel
Copy link
Member Author

this can be updated / merged?

This is good to go

@jreback jreback merged commit 185a654 into pandas-dev:master Apr 10, 2020
@jbrockmendel jbrockmendel deleted the blk-iget branch April 10, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.